Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cross-env with newer package #47

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Replace cross-env with newer package #47

merged 1 commit into from
Oct 1, 2024

Conversation

jdgarcia
Copy link
Contributor

@jdgarcia jdgarcia commented Sep 30, 2024

https://gitkraken.atlassian.net/browse/SOC-427

https://github.com/gitkraken/gk-browser-extension/security/dependabot/1

cross-env hasn't been maintained in 7 years and has a dependency to an old version of babel that contains a critical security vulnerability

@miggy-e you're on Windows right? can you do a quick test to confirm that the commands that use x-var work on your Windows machine please

Copy link
Collaborator

@miggy-e miggy-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me:
image

image

@jdgarcia jdgarcia merged commit 709b828 into main Oct 1, 2024
1 check passed
@jdgarcia jdgarcia deleted the replace-cross-env branch October 1, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants