Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve issue matching with branch names #3894

Open
justinrobots opened this issue Dec 19, 2024 · 1 comment · May be fixed by #3898
Open

Improve issue matching with branch names #3894

justinrobots opened this issue Dec 19, 2024 · 1 comment · May be fixed by #3898
Assignees
Milestone

Comments

@justinrobots
Copy link
Collaborator

The branch for this issue is release-notes-16-1 and GitLens thinks these two issues (#16 and #1) are associated but they are not. I suspect the matching algorithm needs to be refined to avoid mismatches like this.

Image

@justinrobots justinrobots added this to the 16.1-patch milestone Dec 19, 2024
@justinrobots justinrobots modified the milestones: 16.1-patch, 16.2 Dec 19, 2024
@nzaytsev nzaytsev linked a pull request Dec 20, 2024 that will close this issue
7 tasks
@nzaytsev
Copy link
Contributor

I've made some improvements with the non-prefixed autolinks.

  • Now I'm trying to consider issue title and its' matched numbers to remove them from the final list of the autolinks
  • I'm searching for number chunks no longer than 2 numbers
  • I'm trying to ignore the branch name chunks describing the release version as much as it's possible

You can see how it works in the new test group

I actually don't like the way it's done, it's a bit anti-pattern, but now it works slightly more precisely with non-prefixed keys. I'm not sure if it won't make the detection slower. And it still can not work with 100% precise. I described at least a few cases (in the test file) which we can not definitely associate with an issue

In my opinion, we should have a button to de-associate the mismatched issues with the branch. No matter how hard we try to "tune" the autolinks algorithm, the patterns of branch name writing vary greatly from team to team and from user to user.

As @sergeibbb suggests, we could add an additional setting for the autolinks that would disable the basic algorithm and allow the user to use their own pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants