Improves branch autolinks experiments #3898
Open
+257
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I don't quite follow the logic of the added code (specifically, the priority calculation) - some comments throughout might help. @eamodio might have more insight into it.
It didn't seem to help with this case I encountered in my repo. Not a blocker for merge but would be nice if it can accommodate cases like this (the first issue is correct, the second is not):
src/autolinks/autolinks.utils.ts
Outdated
Comment on lines
316
to
322
| console.log( | ||
| JSON.stringify(match.value), | ||
| match.value.groups.numberChunk, | ||
| match.value.groups.numberChunkBeginning, | ||
| match.value.input, | ||
| match.value.groups.issueKeyNumber, | ||
| ); |
There was a problem hiding this comment.
This console log should be removed. Likely left over from when you were testing it locally.
nzaytsev
force-pushed
the
bugs/3894-improve-issue-matching-with-branch-names
branch
from
a342b94 to
6daf177
Compare
nzaytsev
force-pushed
the
bugs/3894-improve-issue-matching-with-branch-names
branch
from
625e1ab to
8e05baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added chunk matching logic for non-prefixed numbers:
considered the distance from the edges of the chunk as a priority sign
the chunk that is more close to the end is more likely actual issue number
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses