Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds GK Provider API Library Integration #2883

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Conversation

axosoft-ramint
Copy link
Contributor

@axosoft-ramint axosoft-ramint commented Aug 24, 2023

-Moves integration authentication session logic into its own domain, migrating that logic out from GitHub and GitLab remotes.

-Adds Azure DevOps and BitBucket authentication prompts (using PATs for now, switching to oAuth in a follow-up PR).

-Adds providers API integration through providersApi and providersService

-Adds the ability to get the authenticated user info from a provider.

-Adds the ability to get PRs and issues for a list of repos from all providers except Jira and Trello.

-Adds the ability to get repos for an Azure Project, which will be useful for project-synced Azure workspaces.

@axosoft-ramint axosoft-ramint requested review from d13 and eamodio August 24, 2023 23:42
@axosoft-ramint axosoft-ramint added area-integrations Issues or features related to integrations feature New feature or request labels Aug 24, 2023
@axosoft-ramint axosoft-ramint force-pushed the feature/shared-providers branch 5 times, most recently from e6d302d to 8737994 Compare August 31, 2023 04:21
@axosoft-ramint axosoft-ramint force-pushed the feature/shared-providers branch 3 times, most recently from 2a7c6f0 to 8e024de Compare September 25, 2023 21:09
@axosoft-ramint axosoft-ramint force-pushed the feature/shared-providers branch 3 times, most recently from 0f0936e to ddcfb2c Compare September 29, 2023 16:27
@axosoft-ramint axosoft-ramint marked this pull request as draft October 2, 2023 18:04
@axosoft-ramint axosoft-ramint force-pushed the feature/shared-providers branch 2 times, most recently from e790e1b to 7958ec5 Compare October 7, 2023 00:35
@axosoft-ramint axosoft-ramint force-pushed the feature/shared-providers branch 4 times, most recently from 5fa7f96 to 353773c Compare October 17, 2023 22:53
@axosoft-ramint axosoft-ramint marked this pull request as ready for review October 17, 2023 22:54
@axosoft-ramint axosoft-ramint force-pushed the feature/shared-providers branch 4 times, most recently from b6d36f0 to c1d692d Compare November 16, 2023 18:10
@axosoft-ramint
Copy link
Contributor Author

@eamodio @d13 This is up-to-date again and ready for review.

@eamodio
Copy link
Member

eamodio commented Nov 17, 2023

@axosoft-ramint I've made a bunch of changes to fully move over to the Integration model and removed the RichRemoteProvider model. I did some very basic sanity checking (and only for GitHub, not GitLab) and it seems to work, but needs a lot more testing.

We also still need to figure out how src/git/remotes/remoteProviderService.ts gets integrated or goes away

@axosoft-ramint axosoft-ramint force-pushed the feature/shared-providers branch from 4fd0ecd to 5102773 Compare November 20, 2023 19:25
eamodio and others added 8 commits November 21, 2023 09:32
Adds filtering support on inputs

Improves types and adds getCurrentUser support

Updates getCurrentUser Fns

Adds GetReposFn for Azure

Reorganizes types and constants

Adds  providers service

Uses correct filter property for Bitbucket PRs

Switches to logged errors

Adds filter compatibility check

Adds paging and per-repo PR/Issue support

Uses PagedResult for paging

Updates dependencies

Updates dependency

Reorganizes and moves provider service logic to providerIntegration

Updates missing provider mappings, ProviderId usage

Updates provider api dependency

Adds enterprise domain passing and GLSH

Uses the correct base api urls

Updates dependency
 - Removes `RichRemoteProvider` in favor of `ProviderIntegration`
 - Implements GitLab integration
 - Fixes caching
 - Fixes GitHub authentication
@axosoft-ramint axosoft-ramint force-pushed the feature/shared-providers branch from bfc3ba8 to 381af39 Compare November 21, 2023 16:33
@axosoft-ramint axosoft-ramint merged commit 690e174 into main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues or features related to integrations feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants