Redesigns Home account footer into new header bar #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 7 out of 17 changed files in this pull request and generated 1 suggestion.
Files not reviewed (10)
- docs/telemetry-events.md: Evaluated as low risk
- src/constants.integrations.ts: Evaluated as low risk
- src/plus/gk/account/__debug__accountDebug.ts: Evaluated as low risk
- src/plus/gk/account/subscriptionService.ts: Evaluated as low risk
- src/plus/integrations/authentication/models.ts: Evaluated as low risk
- src/plus/integrations/integrationService.ts: Evaluated as low risk
- src/webviews/home/protocol.ts: Evaluated as low risk
- src/webviews/home/homeWebview.ts: Evaluated as low risk
- src/webviews/apps/home/stateProvider.ts: Evaluated as low risk
- src/webviews/apps/home/home.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
src/webviews/apps/plus/shared/components/home-header.ts:36
- The commented-out code block should be either removed or uncommented if it is intended to be used.
/* .actions {
| ['prs', 'Pull Requests'], | ||
| ['issues', 'Issues'], | ||
| ]); | ||
| function getIntegrationDetails(integration: IntegrationState): string { |
There was a problem hiding this comment.
The getIntegrationDetails function should handle the case where integration.supports might be empty or contain invalid values.
Suggested change
| function getIntegrationDetails(integration: IntegrationState): string { | |
| const features = integration.supports.map(feature => featureMap.get(feature)).filter(Boolean) as string[]; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
eamodio
force-pushed
the
feature/home-header
branch
2 times, most recently
from
bedef5c to
7bcdd16
Compare
- Adds popover for account information - Adds popover for integration connection and status
eamodio
force-pushed
the
feature/home-header
branch
from
7bcdd16 to
cba28ec
Compare
|
This was approved by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a popover for account information and integration connection and status