Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles editor position change to refresh the webview #3882

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

nzaytsev
Copy link
Contributor

Description

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev requested a review from eamodio December 18, 2024 09:16
@nzaytsev
Copy link
Contributor Author

nzaytsev commented Dec 18, 2024

@eamodio - I know, it's not a perfect solution, but may be used as an idea

Screen.Recording.2024-12-18.at.16.16.53.mov

It would be fine if VSCode api had a field meaning that the editor is floating, but I couldn't find it

@eamodio eamodio force-pushed the bugs/3476-floating-graph branch from 470c5e8 to 3c63313 Compare December 18, 2024 20:42
@eamodio eamodio force-pushed the bugs/3476-floating-graph branch from 3c63313 to f1d876b Compare December 18, 2024 20:45
@eamodio
Copy link
Member

eamodio commented Dec 18, 2024

This is an awesome hack! Thanks!

Tweaked the force to just return (avoids an extra refresh).

@eamodio eamodio marked this pull request as ready for review December 18, 2024 20:45
@eamodio eamodio merged commit ea0dda7 into main Dec 18, 2024
3 checks passed
@nzaytsev nzaytsev linked an issue Dec 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't show commit graph in floating window
2 participants