Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes GitLens XDG-compatible #3904

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Makes GitLens XDG-compatible #3904

wants to merge 1 commit into from
+153 −72

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Dec 23, 2024 •
edited
Loading

Description

All new installs files will be placed into platform specific folder

  • Linux: $XDG_DATA_HOME/gk (~/.local/share/gk)
  • Windows: %LOCALAPPDATA%/gk/Data (C:\Users<user>\AppData\Local\gk\Data)
  • MacOS: ~/Library/Application Support/gk

Existing installs are used $HOME.gk directory. It can be changed manually by deleting .gk directory or moving to corresponding directory

https://github.com/sindresorhus/env-paths/tree/main could be used instead, it implements the logic

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Dec 23, 2024 that may be closed by this pull request
GitLens creates a .gk folder in the home dir. #3660
Open
eamodio
eamodio reviewed Dec 23, 2024
View reviewed changes
src/env/node/pathMapping/sharedGKDataFolder.ts Outdated
}

// export as a singleton
// eslint-disable-next-line import-x/no-default-export
export default new SharedGKDataFolderMapper();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use a default export

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@nzaytsev nzaytsev force-pushed the debt/3660-gitlens-creates-a-gk-folder-in-the-home-dir branch from 5f1a57e to 75caad1 Compare December 24, 2024 02:59
@nzaytsev nzaytsev force-pushed the debt/3660-gitlens-creates-a-gk-folder-in-the-home-dir branch from 75caad1 to 3d08906 Compare December 24, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axosoft-ramint axosoft-ramint Awaiting requested review from axosoft-ramint

@sergeibbb sergeibbb Awaiting requested review from sergeibbb

@eamodio eamodio Awaiting requested review from eamodio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitLens creates a .gk folder in the home dir.
3 participants
@nzaytsev @eamodio @sergeibbb