Add FONLL, mediumID SF and anti-D0 bug fix #2
Conversation
|
Hi Giorgos, Thanks for your PR. You changed the pT asym function to the old version, so please modify it back. For the electron part, could you update all the KEE/KEEMC/KstarEE modules in BParking_modules.py to match the new D0 function like what you did for the muon? Thanks! Best, |
|
Hi Otto, I was using the previous version and therefore I had the bugged version of pT asyymetry functions in UserFunctions.py. I updated it. Regarding the electrons, on Monday's presentation I asked from the rest team to check if the bug affects electrons and if so, to correct it because you are more familiar than me with electrons. Best, |
|
Hi,
So if i understand correctly accepting this PR will actually break the code for electrons right? If so we cannot accept it untill electrons are fixed.
best,
g
…________________________________
From: Georgios Melachroinos ***@***.***
Sent: 17 December 2021 17:47
To: gkaratha/cmgtools-lite
Cc: Subscribed
Subject: Re: [gkaratha/cmgtools-lite] Add FONLL, mediumID SF and anti-D0 bug fix (PR #2)
Hi Otto,
I was using the previous version and therefore I had the bugged version of pT asyymetry functions in UserFunctions.py. I updated it. Regarding the electrons, on Monday's presentation I asked from the rest team to check if the bug affects electrons and if so, to correct it because you are more familiar than me with electrons.
Best,
Giorgos
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEFE64DGQDRORC6YG4W72OTURNSSJANCNFSM5KDT4NTA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
hi George,
yeap, till someone checks what is happening with the electrons, I don't think it is a good idea to apply it.
best,
Giorgos
…________________________________________
From: gkaratha ***@***.***
Sent: 19 December 2021 12:39
To: gkaratha/cmgtools-lite
Cc: Georgios Melachroinos; Author
Subject: Re: [gkaratha/cmgtools-lite] Add FONLL, mediumID SF and anti-D0 bug fix (PR #2)
Hi,
So if i understand correctly accepting this PR will actually break the code for electrons right? If so we cannot accept it untill electrons are fixed.
best,
g
________________________________
From: Georgios Melachroinos ***@***.***
Sent: 17 December 2021 17:47
To: gkaratha/cmgtools-lite
Cc: Subscribed
Subject: Re: [gkaratha/cmgtools-lite] Add FONLL, mediumID SF and anti-D0 bug fix (PR #2)
Hi Otto,
I was using the previous version and therefore I had the bugged version of pT asyymetry functions in UserFunctions.py. I updated it. Regarding the electrons, on Monday's presentation I asked from the rest team to check if the bug affects electrons and if so, to correct it because you are more familiar than me with electrons.
Best,
Giorgos
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEFE64DGQDRORC6YG4W72OTURNSSJANCNFSM5KDT4NTA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AN3MLPHI6IHNE6MY27333J3URWY5DANCNFSM5KDT4NTA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Hi all, I can check the D0 electron part, but I don't have another script to cross-check the result. I assume that if the new function runs and give reasonable result then it is good to go? Otto |
|
Dear all, I checked the D0 module with the B-parking PU unbiased B->Kee MC. I attached the D0 variable distribution in low-q2 region. It looks reasonable to me. I think the code works in electron channel as well. Giorgos: Could you commit the electron part to match everything in the muon part? Thanks! Best,
|
|
Hi Otto, which sample did you use for this plot? Giorgos |
|
Hi Giorgos, B-parking PU unbiased B->Kee MC Otto |
|
If everyone agree this is OK, could Giorgos helps to updated this PR with the electron part? Since this PR is opened by Giorgos, if I want to contribute to this PR, I need to push to Giorgos git repo first, which is quite messy. Once we merged this PR, we can start running CMG to get "version 7.3" ntuples for electron and update the whole study in the electron part. Best, |
No description provided.