Improved completion for variable definitions.

glacyr · Jan 15, 2023 · 030cb55 · 030cb55
1 parent 00d427a
commit 030cb55
Showing 1 changed file with 18 additions and 12 deletions.
diff --git a/litho-lsp/src/completion.rs b/litho-lsp/src/completion.rs
@@ -189,18 +189,6 @@ impl<'a> CompletionVisitor<'a> {
 
         let name = match ty {
             Type::List(_) => {
-                // items.push(CompletionItem {
-                //     label: "[".to_owned(),
-                //     label_details: Some(CompletionItemLabelDetails {
-                //         detail: Some("...]".to_owned()),
-                //         description: None,
-                //     }),
-                //     insert_text: Some("[${0}]".to_owned()),
-                //     insert_text_format: Some(InsertTextFormat::SNIPPET),
-                //     kind: Some(CompletionItemKind::OPERATOR),
-                //     ..Default::default()
-                // });
-
                 return items.into_iter();
             }
             ty => match ty.name() {
@@ -460,4 +448,22 @@ impl<'a> Visit<'a, SmolStr> for CompletionVisitor<'a> {
             _ => {}
         }
     }
+
+    fn visit_variable_definitions(
+        &self,
+        node: &'a VariableDefinitions<SmolStr>,
+        accumulator: &mut Self::Accumulator,
+    ) {
+        if !node.parens.span().contains(self.offset) {
+            return;
+        }
+
+        for definition in node.variable_definitions.iter() {
+            if !definition.colon.span().before(self.offset) {
+                continue;
+            }
+
+            accumulator.extend(self.complete_all_types(true));
+        }
+    }
 }