Dev df http config #270
Open
Dev df http config #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated gleanerConfig.go to fetch config via HTTP and added a new flag in main.go to specify configuration URLs. This enhancement allows flexibility in supplying configuration either from a local file or a remote URL.
Introducing a new cfgURL flag to specify configuration URLs. Additionally, sensitive fields in localConfig.yaml such as accessKey and secretKey have been cleared for better security practices. This update improves configuration flexibility and enhances security.
Renamed flags from `cfgurl` to `cfgURL` for consistency in `main.go`. Added multiple new indirect dependencies in `go.mod` for enhanced functionality.
valentinedwv
approved these changes
Nov 15, 2024
Enhanced the gleaner configuration loading logic to support fetching the config file from a URL. This update provides an alternative to local file configuration, improving flexibility and usability.
|
@valentinedwv I think the update to glcon is in.. I think that is all that is needed, but wanted to check with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@valentinedwv here is the pull request for Gleaner for adding in --cfgURL
I see I didn't propergate these changes into glcon, just the gleaner binary.
I will do that now but wanted to get this in in case working with the gleaner binary was enough. Also lets you vet the changes. Will do another PR when the code is worked into glcon too.