Update setters to accept default values #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidStirling
requested changes
Nov 21, 2023
There was a problem hiding this comment.
These changes do make the setters accept null values where needed, however because the setting values are no longer initialised by the Converter class there are no longer effective defaults outside of the CLI interface.
As a minimal example, I would expect that creating a Converter and setting input & output would be enough to run .call() with some standard settings assumed, however with this PR that method will now fail because a bunch of settings are null and this is unhandled within the executor.
I would suggest that either we continue initialising these settings on creation, or the Converter should accept null arguments when called and take that as a prompt to fetch the picocli default.
DavidStirling
approved these changes
Nov 28, 2023
sbesson
requested changes
Nov 29, 2023
…to picocli-default-reset
sbesson
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and define default values in the way that picocli expects them. Replaces #219, see discussion starting at #219 (comment).