flutter upgrade dcdg #62
Conversation
upgrade analyzer to 4.7.0
dependencies: analyzer: ^4.7.0 args: ^2.3.1 path: ^1.8.2 dev_dependencies: lints: ^2.0.1 test: ^1.21.6
| @@ -338,4 +331,4 @@ packages: | |||
| source: hosted | |||
| version: "3.1.0" | |||
| sdks: | |||
| dart: ">=2.14.0 <3.0.0" | |||
| dart: ">=2.18.0 <3.0.0" | |||
There was a problem hiding this comment.
I'd prefer to be backward compatible as far as possible. There are users who are still on older versions of Dart.
There was a problem hiding this comment.
I put an example :
Mockito is incompatible with your library.
If you need to make unit testing with mock your library is invalid.
That's the reason I suggested these changes.
There was a problem hiding this comment.
Mockito supports Dart 2.17, see https://github.com/dart-lang/mockito/blob/master/pubspec.yaml#L9, so, at the very least, we can lower adjust the lower bound here.
There was a problem hiding this comment.
You can also globally activate DCDG, you don't need to have it in your dependencies.
There was a problem hiding this comment.
Maybe I'm missing something but why not keep your package up to date? If someone needs to run an older version to support their project, they can activate an older version.
There was a problem hiding this comment.
Because I want the latest version to work with as many versions of Dart as possible.
There was a problem hiding this comment.
I understand that, sort of, but it seems like your desire to support older versions is going to make your tool useless with newer versions of dart with new language constructs and new versions of the analyzer 🤷. Again, just in case you weren't aware... you can activate packages with version constraints.
There was a problem hiding this comment.
I was trying to use this library on a project running the latest versions of Flutter and Dart and I'm facing the problem that this PR would solve.
There was a problem hiding this comment.
@Rexobias I activated the global package using dart pub global activate -sgit https://github.com/gonojuarez/dcdg.dart
But it's still giving me the below error
╰─ dcdg . ─╯
Unhandled exception:
Null check operator used on a null value
#0 ElementAnnotationExtensions.targetKinds (package:analyzer/src/dart/element/extensions.dart:42:51)
#1 BestPracticesVerifier.visitAnnotation (package:analyzer/src/error/best_practices_verifier.dart:323:25)
#2 AnnotationImpl.accept (package:analyzer/src/dart/ast/ast.dart:318:50)
#3 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:8777:20)
#4 AnnotatedNodeImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:154:17)
#5 ClassDeclarationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:1823:11)
#6 RecursiveAstVisitor.visitClassDeclaration (package:analyzer/dart/ast/visitor.dart:793:10)
#7 BestPracticesVerifier.visitClassDeclaration (package:analyzer/src/error/best_practices_verifier.dart:404:13)
#8 ClassDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:1799:50)
#9 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:8777:20)
#10 CompilationUnitImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:2455:21)
#11 RecursiveAstVisitor.visitCompilationUnit (package:analyzer/dart/ast/visitor.dart:817:10)
#12 CompilationUnitImpl.accept (package:analyzer/src/dart/ast/ast.dart:2448:50)
#13 LibraryAnalyzer._computeHints (package:analyzer/src/dart/analysis/library_analyzer.dart:344:10)
#14 LibraryAnalyzer._computeDiagnostics.<anonymous closure> (package:analyzer/src/dart/analysis/library_analyzer.dart:274:9)
#15 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:633:13)
#16 LibraryAnalyzer._computeDiagnostics (package:analyzer/src/dart/analysis/library_analyzer.dart:273:13)
#17 LibraryAnalyzer.analyze (package:analyzer/src/dart/analysis/library_analyzer.dart:92:5)
#18 AnalysisDriver._computeAnalysisResult.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:1373:11)
<asynchronous suspension>
#19 PerformanceLog.runAsync (package:analyzer/src/dart/analysis/performance_logger.dart:50:14)
<asynchronous suspension>
#20 AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1081:24)
<asynchronous suspension>
#21 AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2171:7)
<asynchronous suspension>
#0 AnalysisDriver._computeAnalysisResult.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:1402:9)
<asynchronous suspension>
#1 PerformanceLog.runAsync (package:analyzer/src/dart/analysis/performance_logger.dart:50:14)
<asynchronous suspension>
#2 AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1081:24)
<asynchronous suspension>
#3 AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2171:7)
<asynchronous suspension>
How did you get this working?
There was a problem hiding this comment.
I'd prefer to be backward compatible as far as possible. There are users who are still on older versions of Dart.
That is a strange motivation to make your package unusable to everyone but developers with old versions of Dart, who have need and time to upgrade to latest dcdg instead of upgrading their old Dart dependencies.
upgrade analyzer to 4.7.0