Disable header row marker on single selection #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
commented
Apr 3, 2024
| @@ -1795,7 +1798,7 @@ const DataEditorImpl: React.ForwardRefRenderFunction<DataEditorRef, DataEditorPr | |||
| } else { | |||
| setSelectedRows(CompactSelection.fromSingleSelection(newSlice), undefined, isMultiRow); | |||
| } | |||
| } else if (isMultiRow || args.isTouch || rowSelectionMode === "multi") { | |||
| } else if (rowSelect === "multi" && (isMultiRow || args.isTouch || rowSelectionMode === "multi")) { | |||
There was a problem hiding this comment.
An additional check for rowSelect == multi here to make sure that multi-selection is only allowed if it is actually configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring
rowSelectassinglestill shows a not-functional checkbox in the row marker header. I would expect that this isn't shown since this feature doesn't really make sense for single-row selection. This PR disables the row marker header forrowSelect==single.Screen.Recording.2024-04-02.at.22.21.52.mov
Closes #934
In addition, in the current impl. it was also possible to have multi-selection even if
row selectis set tosingle.For example, touch devices would falsely allow multi-selection. This PR also enforces thesingleconfiguration.