-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "exports" to package.json #700
add "exports" to package.json #700
Conversation
this fixes ESM import fixes TanStack/router#2802
Thanks! |
Hey @jedrzejchalubek, thanks for working on Glide. This change broke my modular import: import Glide, {Images, Swipe} from '@glidejs/glide/dist/glide.modular.esm'; With the error message below:
Reverting to 3.6.2 resolved the issue. How should I import it on the new version? Also, I guess it is related, all SCSS imports stopped working:
Reverting to 3.6.2 also resolved this. |
I'm facing the same issue 😢 |
Similarly this looks to have broken on the @calcom project: |
Fixes glidejs#700, glidejs#701 so that `import "@glidejs/glide/css/glide.core.css"` for example works again
@rodrigopedra @dzakki Can you check if import simply as this will work for you?
This should be all what is needed when project has Looks like, some additional exports needs to be set up in order to CSS and SCSS imports to work, need to verify it |
Unfortunately, I can't add Tried adding it, but couldn't run. An upgrade to this project is planned for the following months, so for now, I will just keep glide fixed at 3.6.2. Thanks for looking into it @jedrzejchalubek, and thanks for this great project |
this fixes ESM import
fixes TanStack/router#2802