Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better express the dependency on spree_product_asssembly #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thisiscab
Copy link
Contributor

A major problem right now is that the way we are using the assembly gem
in our fork is different of the original implementation.

Instead of a product having parts (which is the case in our fork),
variants have parts (in the original implementation). We'll have to
figure something out.

This solves #37

A major problem right now is that the way we are using the assembly gem
in our fork is different of the original implementation.

Instead of a product having parts (which is the case in our fork),
variants have parts (in the original implementation). We'll have to
figure something out.

This solves #37
@thisiscab thisiscab self-assigned this Sep 28, 2016
I keep forgetting about that part.
@thisiscab
Copy link
Contributor Author

The problem I had expressed:

Instead of a product having parts (which is the case in our fork),
variants have parts (in the original implementation). We'll have to
figure something out.

Was not true. I just had made a dummy mistake :)

@braidn
Copy link
Contributor

braidn commented Sep 29, 2016

@cabouffard did you ping anyone here for a Code review?

@thisiscab
Copy link
Contributor Author

Ping @braidn @DanielWright @bryanmtl
Here is part of the argument: #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants