Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shape family tests #211

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Improve shape family tests #211

merged 4 commits into from
Jan 19, 2024

Conversation

janbridley
Copy link
Collaborator

@janbridley janbridley commented Jan 18, 2024

Description

More tests were added and current tests were expanded for test_shape_families.py

Motivation and Context

Plane shape families can result in unexpected errors with parameter values close to transition points in shape space. More tests were added to cover this possibility, and integer values were replaced with "exact" floats to verify that transition point shapes can be generated. These tests confirm that the unexpected failures are a result of floating point precision, and not a deeper bug in the implementation. Also note that before #188 these functions return incorrect results rather than raising an error.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

@janbridley janbridley requested review from a team and DomFijan and removed request for a team January 18, 2024 20:02
@janbridley janbridley force-pushed the improve-shape-family-tests branch from 180def7 to a446db2 Compare January 18, 2024 20:08
@janbridley janbridley self-assigned this Jan 18, 2024
@janbridley janbridley enabled auto-merge (squash) January 18, 2024 20:29
Copy link
Contributor

@DomFijan DomFijan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are 1000 max examples really needed for intermediates? it feels like this can be significantly reduced?

@janbridley
Copy link
Collaborator Author

Are 1000 max examples really needed for intermediates? it feels like this can be significantly reduced?

Hypothesis does sample better with 1000 examples, but the behavior is confirmed with the default 200 samples. I will adjust that down!

@janbridley janbridley disabled auto-merge January 18, 2024 22:45
@janbridley janbridley enabled auto-merge (squash) January 19, 2024 15:27
@janbridley janbridley requested a review from DomFijan January 19, 2024 15:28
@janbridley janbridley merged commit 576bd75 into master Jan 19, 2024
8 checks passed
@janbridley janbridley deleted the improve-shape-family-tests branch January 19, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants