Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More tests were added and current tests were expanded for
test_shape_families.py
Motivation and Context
Plane shape families can result in unexpected errors with parameter values close to transition points in shape space. More tests were added to cover this possibility, and integer values were replaced with "exact" floats to verify that transition point shapes can be generated. These tests confirm that the unexpected failures are a result of floating point precision, and not a deeper bug in the implementation. Also note that before #188 these functions return incorrect results rather than raising an error.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist: