Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Garnett as a Testing Dependency #1133

Merged
merged 9 commits into from
Aug 7, 2023
Merged

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR removes garnett from freud's test suite.

Motivation and Context

We plan to support gsd>=3.0.0 in the future and garnett cannot read gsd>=3.0 files due to changes in gsd's read/write mode flags.

How Has This Been Tested?

Garnett has been removed from usage in freud's tests, so if the remaining tests pass we are good to go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@tommy-waltmann
Copy link
Collaborator Author

This should be merged after #1132

@joaander joaander mentioned this pull request Jul 26, 2023
11 tasks
@tommy-waltmann tommy-waltmann marked this pull request as ready for review August 2, 2023 17:17
@tommy-waltmann tommy-waltmann requested review from a team as code owners August 2, 2023 17:17
@tommy-waltmann tommy-waltmann requested review from b-butler and removed request for a team August 2, 2023 17:17
Copy link
Member

@b-butler b-butler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Do we still plan to advertise garnett support given its unmaintained status?

@tommy-waltmann
Copy link
Collaborator Author

Looks fine to me. Do we still plan to advertise garnett support given its unmaintained status?

Let's make an issue for it. I don't have the bandwidth to address this right now, but at some point docs pages should be updated.

@tommy-waltmann
Copy link
Collaborator Author

issue created in #1142

@tommy-waltmann tommy-waltmann merged commit ce57639 into master Aug 7, 2023
@tommy-waltmann tommy-waltmann deleted the remove-garnett branch August 7, 2023 17:44
@tommy-waltmann tommy-waltmann added this to the v2.13.1 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants