-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Garnett as a Testing Dependency #1133
Conversation
This should be merged after #1132 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Do we still plan to advertise garnett support given its unmaintained status?
Let's make an issue for it. I don't have the bandwidth to address this right now, but at some point docs pages should be updated. |
issue created in #1142 |
Description
This PR removes
garnett
from freud's test suite.Motivation and Context
We plan to support
gsd>=3.0.0
in the future andgarnett
cannot readgsd>=3.0
files due to changes in gsd's read/write mode flags.How Has This Been Tested?
Garnett has been removed from usage in freud's tests, so if the remaining tests pass we are good to go.
Types of changes
Checklist: