Remove addTypes and related methods #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaander
requested review from
a team,
b-butler and
thiv89
and removed request for
a team
joaander
added
the
validate
b-butler
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
addTypes,slotNumTypesChanged, the ParticleData signal for types changing, and related code.Motivation and context
This code is complex, untested, and contains numerous bugs. Fixing these all is not worth the effort. Users can include all possible types in the initial configuration, even if they are not all used in the first step.
Resolves #664
How has this been tested?
The code compiles and unit tests pass.
Change log
No change log necessary. This is an internal change to C++ code in a feature that has not been exposed in v3.
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.