Fix deadlock and message file retention on Frontier. #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
simulation.walltime
evaluations from insiderank == 0
checks.Motivation and context
communicator.walltime
calls MPI_Bcast and therefore must be called collectively. I opted to remove the walltime message rather than callcommunicator.walltime
collectively and print the result.message_file
was overwritten on job restart. Tag the file with the slurm job id to keep old logs.How has this been tested?
For unknown reasons, this does not always deadlock as I would expect. It only deadlocks in very rare circumstances in job submissions on OLCF Frontier. I have tested the
create_initial_state
operations on Frontier and they work now.TODO:
Checklist:
CONTRIBUTORS.md
) in the pull request source branch.