Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.6.0 #194

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Release/0.6.0 #194

merged 3 commits into from
Aug 31, 2023

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Aug 30, 2023

Description

Release Navigator module and Login page plus security fixes

Checklist:

@cbkerr cbkerr requested review from a team as code owners August 30, 2023 20:54
@cbkerr cbkerr requested review from tcmoore3 and tommy-waltmann and removed request for a team August 30, 2023 20:54
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #194 (3589c75) into main (81981c1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   69.98%   69.98%           
=======================================
  Files          21       21           
  Lines         883      883           
  Branches      159      159           
=======================================
  Hits          618      618           
  Misses        220      220           
  Partials       45       45           
Files Changed Coverage Δ
signac_dashboard/version.py 100.00% <100.00%> (ø)

@cbkerr
Copy link
Member Author

cbkerr commented Aug 30, 2023

The run of the Publish to TestPyPI check after the pre-commit bot failed, but I think the publication worked because the URL is live: https://test.pypi.org/project/signac-dashboard/0.6.0/

Copy link

@tommy-waltmann tommy-waltmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it uploaded right, but it may still be worth looking the failure report. Is that action failing something that typically happens on release?

@cbkerr
Copy link
Member Author

cbkerr commented Aug 30, 2023

It looks like it uploaded right, but it may still be worth looking the failure report. Is that action failing something that typically happens on release?

I should have pasted the error, but yes it was that the file was uploaded already:

WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         File already exists. See https://test.pypi.org/help/#file-name-reuse   
         for more information. 

I recall something like this happening on an earlier release where there were extra steps (and one time where I made the version tag wrong) but I think any Slack chat history about it is deleted bc it's been more than 90 days.

@joaander
Copy link
Member

It looks like it uploaded right, but it may still be worth looking the failure report. Is that action failing something that typically happens on release?

I should have pasted the error, but yes it was that the file was uploaded already:

WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         File already exists. See https://test.pypi.org/help/#file-name-reuse   
         for more information. 

I recall something like this happening on an earlier release where there were extra steps (and one time where I made the version tag wrong) but I think any Slack chat history about it is deleted bc it's been more than 90 days.

I use the skip_existing option to silence this type of error:
https://github.com/glotzerlab/gsd/blob/de226fed1862ae2a3a76ac9ef06ce6df4eb970f5/.github/workflows/build_wheels.yml#L99C2-L107

The alternative is to add a suffix to the generated wheel so that each upload succeeds. However, you may then accumulate MANY wheels in the testpypi project.

@bdice
Copy link
Member

bdice commented Aug 31, 2023

Historically this has always failed if multiple commits are pushed to a release branch — and “skip existing” sounds like the right way to fix this problem. I wasn’t aware of that option when I set up the deployment workflow but would support adding that flag.

@cbkerr cbkerr merged commit 03108ed into main Aug 31, 2023
@cbkerr cbkerr deleted the release/0.6.0 branch August 31, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants