-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning when capitalized booleans (improper JSON) appear in query #213
Conversation
The warning from signac.filterparse._cast is burried in the shell and automatically searching for capitalized boolean string is likely not the expected result.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 70.02% 69.55% -0.48%
==========================================
Files 21 21
Lines 884 890 +6
Branches 159 162 +3
==========================================
Hits 619 619
- Misses 220 223 +3
- Partials 45 48 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks fine after the suggested rephrasing of the message.
Co-authored-by: Joshua A. Anderson <[email protected]>
for more information, see https://pre-commit.ci
The warning from signac.filterparse._cast is burried in the shell and automatically searching for capitalized boolean string is likely not the expected result.
Description
Make the feedback when searching for booleans in incorrect JSON more like
signac find
:Motivation and Context
You would have to look at the shell to see these messages about casting of True-->true.
They come from
signac.filterparse._cast
Related to glotzerlab/signac-docs#199
Checklist: