Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions CI #67

Merged
merged 28 commits into from
Nov 4, 2023
Merged

Migrate to GitHub Actions CI #67

merged 28 commits into from
Nov 4, 2023

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Nov 3, 2023

Migrates signac-examples to use GitHub Actions. Also upgrades the HOOMD notebook to use HOOMD version 4.

Closes #66.

@bdice bdice changed the title First pass inspired by signac-dashboard and freud actions Migrate to GitHub Actions CI Nov 3, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bdice
Copy link
Member

bdice commented Nov 4, 2023

@cbkerr I think this is ready. Please take a look when you have a moment, but I am planning to go ahead and merge once things pass so that I can update the examples in the documentation (which has been out of date).

@bdice bdice assigned bdice and cbkerr Nov 4, 2023
@bdice bdice marked this pull request as ready for review November 4, 2023 20:40
@bdice bdice requested review from a team as code owners November 4, 2023 20:40
@bdice bdice requested review from csadorf and Charlottez112 and removed request for a team November 4, 2023 20:40
@bdice bdice enabled auto-merge November 4, 2023 20:41
@bdice
Copy link
Member

bdice commented Nov 4, 2023

Follow-up work is already captured in issues: we need to re-enable the flow.hoomd.lj notebook, which still uses HOOMD 2 (see #18). Also we should complete #64 by removing or updating the other outdated tutorials.

@bdice bdice disabled auto-merge November 4, 2023 20:43
@bdice bdice merged commit 794fdb7 into main Nov 4, 2023
3 checks passed
@bdice bdice deleted the github-actions branch November 4, 2023 20:43
@bdice
Copy link
Member

bdice commented Nov 4, 2023

Docs are updated here: glotzerlab/signac-docs@956b2ff

edit: ...and they're live. Great!

@cbkerr
Copy link
Member Author

cbkerr commented Nov 6, 2023

@bdice I had a few questions

  1. Why did you choose to run all projects within the CI job as opposed to making a separate action for each test project? I guess 3 min isn't too long to wait if repeatedly testing only one of the projects.
  2. What happened to fix the import error we had on early tests on the line from mistune import BlockLexer?

@bdice
Copy link
Member

bdice commented Nov 7, 2023

  1. If we expand the CI matrix to include more OS or Python versions, we'd end up with way too many jobs if we have (OS x Python x Projects). I decided the runtime was fast enough, and the previous CI was designed to run in a single job so I decided to just keep it in the same design. I also wanted to take advantage of run-tests.sh. That script already knows which projects to run or skip via the presence of .skipci files, and it also knows how to detect and install any additional requirements for each project.
  2. The error ModuleNotFoundError: No module named 'mistune' was resolved by activating the conda environment. We overlooked an "IMPORTANT" note earlier from the setup-miniconda README. We hadn't noticed that the shell needed to be set to shell: bash -el {0}. b54fa1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI to GitHub Actions
2 participants