Add support for axis stretches #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of clip boundary calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently plugin exports don't respect the axis stretch values of the viewer state. This PR adds support for stretches, and generally cleans up the functions related to putting the coordinates of the exported data into clip space.
The current approach of the plugin is to do the following: in native aspect mode, we make the largest coordinate range to (-1, 1) and others to the appropriate fraction. In non-native aspect mode, every range is mapped to (-1, 1).
With this PR, in native aspect mode we instead find the max of (range * stretch) across coordinates, which gets mapped to (-1, 1), and map other axis to range * stretch / max(range * stretch). And in non-native aspect mode, we map the range that's maximally stretched to (-1,1), and the others to the appropriate fraction.