Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sliders for numerical values and combine resolutions #89

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

Carifio24
Copy link
Member

This PR makes two primary changes to the export dialogs:

  • Use sliders rather than text fields for numerical values. For now we set integer values to have a range of [1, 100], and floats to have a range of [0.01, 1] with a precision of 0.01. This works well for all of the quantities that we currently have (floats are used only for opacities at the moment), but if that's not the case later we can revisit.
  • Per a suggestion from Michelle, combine theta and phi resolutions for scatter spheres into just "resolution" at the user dialog level. Internally all of our functions still support making theta and phi resolutions different.

@Carifio24 Carifio24 added Qt Related to Qt export tools Jupyter Related to Jupyter export tools scatter labels Nov 20, 2024
@Carifio24 Carifio24 merged commit 8d28425 into glue-viz:master Nov 20, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jupyter Related to Jupyter export tools Qt Related to Qt export tools scatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant