Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer test against casatools and casatasks #66

Merged
merged 4 commits into from
Feb 25, 2022

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Feb 24, 2022

... since spectral-cube now depends on casa-formats-io by default

Fixes #65

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #66 (1067dc0) into main (b0c598c) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   96.13%   96.48%   +0.34%     
==========================================
  Files          15       15              
  Lines        1139     1137       -2     
==========================================
+ Hits         1095     1097       +2     
+ Misses         44       40       -4     
Impacted Files Coverage Δ
...onomy/io/spectral_cube/tests/test_spectral_cube.py 100.00% <100.00%> (+10.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c598c...1067dc0. Read the comment docs.

@dhomeier
Copy link
Contributor

dhomeier commented Feb 24, 2022

Has the interface/format changed from casatools to casa-formats-io?

            if os.path.isdir(datafn):
>               raise OSError("Tried to access a data file that's actually "
E               OSError: Tried to access a data file that's actually a package data directory

cube_3d.image does not look like any standard format, but I currently cannot access any pkg_data files under data/ (getting a 404 from two different IPs here), so cannot check.

@dhomeier
Copy link
Contributor

dhomeier commented Feb 24, 2022

if os.path.isdir(datafn):
>               raise OSError("Tried to access a data file that's actually "
E               OSError: Tried to access a data file that's actually a package data directory

Ah, it's get_pkg_data_filename itself stumbling on this:
https://github.com/glue-viz/glue-astronomy/pull/64/files#r814350245
@pllim is there any trick to work around this using, say get_pkg_data_filenames (plural!) or get_pkg_data_path? Both seem to be able to retrieve the local path in tests/data, but I suppose they will not take care of the automatic remote retrieval?

setup_requires =
setuptools_scm
install_requires =
astropy>=4.0
glue-core>=1.0
regions>=0.4
specutils>=0.7
spectral-cube>=0.5.0
spectral-cube>=0.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't like this. See #62

@pllim
Copy link
Contributor

pllim commented Feb 25, 2022

@astrofrog , @dhomeier , see astrofrog#1 (PR to this PR)

@astrofrog astrofrog merged commit 347cb41 into glue-viz:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT: Drop Python 3.6
3 participants