Added regression test for bug that caused image viewer to turn green when an incompatible subset was present #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when an incompatible subset was present
astrofrog
force-pushed
the
regression-test-green-subset
branch
from
c1eae87 to
7a723b8
Compare
astrofrog
force-pushed
the
regression-test-green-subset
branch
from
07d5388 to
f54d781
Compare
1 task
astrofrog
force-pushed
the
regression-test-green-subset
branch
from
d15cb18 to
144419e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 86.62% 86.37% -0.26%
==========================================
Files 89 90 +1
Lines 5130 5151 +21
==========================================
+ Hits 4444 4449 +5
- Misses 686 702 +16
☔ View full report in Codecov by Sentry. |
|
Well I never got this to work, closing as not worth putting more effort into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression test for bug fixed by glue-viz/glue#2425 - at the moment the regression test should fail but I will do a new release of glue-core and update the minimum version here and make sure the test passes.