Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated configuration key for readthedocs #405

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

dhomeier
Copy link
Contributor

@dhomeier dhomeier commented Oct 23, 2023

Description

The configuration key "build.image" is deprecated.

Unfortunately the replacement os only accepts a specific version and is also non-optional, so I see this break again whenever ubuntu-22.04 should be no longer available.

@dhomeier dhomeier added documentation skip-changelog Changelog entry not needed or added manually labels Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0976a06) 86.62% compared to head (3cbeaa9) 86.62%.
Report is 1 commits behind head on main.

❗ Current head 3cbeaa9 differs from pull request most recent head f1a6209. Consider uploading reports for the commit f1a6209 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files          89       89           
  Lines        5130     5130           
=======================================
  Hits         4444     4444           
  Misses        686      686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhomeier dhomeier force-pushed the rtd-build.os branch 3 times, most recently from 3cbeaa9 to ca3cc41 Compare October 23, 2023 14:30
@astrofrog astrofrog merged commit 09c882d into glue-viz:main Oct 23, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation skip-changelog Changelog entry not needed or added manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants