Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set large data limits since the warning appears too late anyway #406

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

astrofrog
Copy link
Member

This will stop the following warnings:

/Users/tom/Dropbox/Code/Glue/glue/glue/viewers/common/viewer.py:188: UserWarning: Add large data set?
  warnings.warn(message)

which appeared too late anyway and were not a real prompt. In future we could always choose to add a UI prompt in Jupyter and re-enable this.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09c882d) 86.62% compared to head (3cefde6) 86.61%.
Report is 2 commits behind head on main.

❗ Current head 3cefde6 differs from pull request most recent head a93b673. Consider uploading reports for the commit a93b673 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   86.62%   86.61%   -0.02%     
==========================================
  Files          89       89              
  Lines        5130     5124       -6     
==========================================
- Hits         4444     4438       -6     
  Misses        686      686              
Files Coverage Δ
glue_jupyter/bqplot/histogram/viewer.py 100.00% <ø> (ø)
glue_jupyter/bqplot/image/viewer.py 87.32% <ø> (-0.18%) ⬇️
glue_jupyter/bqplot/scatter/viewer.py 100.00% <ø> (ø)
glue_jupyter/ipyvolume/scatter/viewer.py 100.00% <ø> (ø)
glue_jupyter/ipyvolume/volume/viewer.py 100.00% <ø> (ø)
glue_jupyter/table/viewer.py 88.29% <ø> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…. This could be added back as part of a full UI if needed but doesn't make sense in a notebook context
@astrofrog astrofrog force-pushed the no-large-data-warning branch from 3cefde6 to a93b673 Compare October 26, 2023 10:55
@astrofrog astrofrog merged commit ec74442 into glue-viz:main Oct 26, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant