Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for bug that caused histogram viewer to crash when removing datasets #407

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

astrofrog
Copy link
Member

This is a test for this bug: glue-viz/glue#2451 - as manifested in glue-jupyter (so no fix required here aside from updating the minimum required version of glue-core)

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e973b88) 86.61% compared to head (32e0700) 86.60%.
Report is 2 commits behind head on main.

❗ Current head 32e0700 differs from pull request most recent head 04b4844. Consider uploading reports for the commit 04b4844 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   86.61%   86.60%   -0.02%     
==========================================
  Files          89       89              
  Lines        5140     5142       +2     
==========================================
+ Hits         4452     4453       +1     
- Misses        688      689       +1     
Files Coverage Δ
glue_jupyter/bqplot/histogram/tests/test_viewer.py 94.00% <76.92%> (-6.00%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog astrofrog force-pushed the test-histogram-data-remove branch from 601bd28 to 04b4844 Compare October 26, 2023 11:09
@astrofrog astrofrog merged commit 0a1211a into glue-viz:main Oct 26, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant