-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of latest improvements to custom stretches in glue-core #409
Conversation
@@ -264,7 +264,7 @@ def _update_visual_attributes(self, changed, force=False): | |||
self.density_mark.vmax = self.state.cmap_vmax | |||
|
|||
if force or "stretch" in changed: | |||
self.density_mark.stretch = STRETCHES[self.state.stretch]() | |||
self.density_mark.stretch = self.state.stretch_object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astrofrog: should this be made dependent on version or availability of stretch_object
, or glue-core version requirement be bumped to 1.17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just bump the requirements to 1.17
We should restart the CI once 1.17.0 is on PyPI (build ongoing) |
65f7720
to
a266104
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – there is no test directly testing the new functionality, right?
No but the failing visual test is actually highlighting a real issue/bug in glue-core related to the stretches. |
a266104
to
0e892a5
Compare
0e892a5
to
4d4400b
Compare
The hashes have changed for the figures but the diffs are actually empty and the baseline images match so it's safe to update the hashes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 89 89
Lines 5163 5163
=======================================
Hits 4473 4473
Misses 690 690 ☔ View full report in Codecov by Sentry. |
Oh, that was for https://app.circleci.com/pipelines/github/glue-viz/glue-jupyter/179/workflows/bdb8770a-7e15-466f-bf9b-9738d3085928/jobs/201/artifacts , so fixed by glue 1.17.1 it seems. |
Companion to glue-viz/glue#2453