Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for bitmap_visible in image viewer #412

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix support for bitmap_visible in image viewer #412

merged 1 commit into from
Dec 1, 2023

Conversation

astrofrog
Copy link
Member

Fix the case where visible is True but bitmap_visible is False in image viewer

kecnry
kecnry approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick - thanks!

@dhomeier dhomeier added bug Something isn't working bqplot-viewers labels Nov 30, 2023
@dhomeier
Copy link
Contributor

dhomeier commented Nov 30, 2023 •
edited
Loading

circleci failure is unrelated
publish seems to fail on a wheel build, apparently for runipy, not sure what to do about that.

dhomeier
dhomeier approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI failure has shown up before; publish failure due to #413.

@astrofrog astrofrog merged commit bc5ffdb into glue-viz:main Dec 1, 2023
22 of 24 checks passed
@kecnry kecnry mentioned this pull request Dec 7, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kecnry kecnry kecnry approved these changes

@dhomeier dhomeier dhomeier approved these changes

Assignees
No one assigned
Labels
bqplot-viewers bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astrofrog @dhomeier @kecnry