-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mpl.colormaps.get_cmap
for compatibility with matplotlib 3.9
#422
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 86.63% 86.61% -0.03%
==========================================
Files 89 89
Lines 5163 5169 +6
==========================================
+ Hits 4473 4477 +4
- Misses 690 692 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no tests for that functionality which may be the reason we missed the deprecation phase, but I've tested the options for matplotlib 3.3.4-3.9.0dev.
There is one other use in utils.py
that should also be updated along with this; I think scalar_to_png_data
should support Colormap
and thus use get_cmap
even more than here. Thanks!
Co-authored-by: Derek Homeier <[email protected]>
Thanks for the review, @dhomeier ! I think I have applied all your comments. Does it look good now? |
mpl.colormaps.get_cmap
for compatibility with matplotlib 3.9
mpl.colormaps.get_cmap
for compatibility with matplotlib 3.9mpl.colormaps.get_cmap
for compatibility with matplotlib 3.9
Looks all good, and thanks for the isort cleanup, too! |
Fix #421 , maybe.