Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit conversion for contour levels #423

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

astrofrog
Copy link
Member

Allow the units used to show the contour levels to be customized.

Work in progress!

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 49.23077% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 86.12%. Comparing base (b46e487) to head (a470bc2).
Report is 2 commits behind head on main.

❗ Current head a470bc2 differs from pull request most recent head 2e0f056. Consider uploading reports for the commit 2e0f056 to get more accurate results

Files Patch % Lines
glue_jupyter/bqplot/image/tests/test_visual.py 23.07% 20 Missing ⚠️
glue_jupyter/bqplot/image/state.py 59.37% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   86.60%   86.12%   -0.49%     
==========================================
  Files          89       90       +1     
  Lines        5167     5226      +59     
==========================================
+ Hits         4475     4501      +26     
- Misses        692      725      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javerbukh
Copy link
Contributor

Jdaviz implementation of contour unit conversion: spacetelescope/jdaviz#2702

@astrofrog astrofrog force-pushed the contour-level-units branch from 5591fde to a470bc2 Compare March 19, 2024 10:37
@astrofrog astrofrog force-pushed the contour-level-units branch from a470bc2 to 3ce8770 Compare April 16, 2024 13:59
@astrofrog astrofrog marked this pull request as ready for review April 16, 2024 14:10
@astrofrog
Copy link
Member Author

Looks like the CircleCI test failure is real, will try and take a look tomorrow morning.

@astrofrog astrofrog merged commit dcddade into glue-viz:main Apr 17, 2024
24 checks passed
@astrofrog astrofrog added the enhancement New feature or request label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants