Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Qt sessions to Jupyter sessions #459

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

astrofrog
Copy link
Member

Work in progress, seems to work for basic plot types but need to work on 3D viewers and WWT. Also need to decide on an API and a way to select which widgets to use (bqplot vs matplotlib, vispy vs ipyvolume)

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 69.86301% with 22 lines in your changes missing coverage. Please review.

Project coverage is 85.84%. Comparing base (54499a8) to head (6c8ad30).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
glue_jupyter/session.py 36.84% 12 Missing ⚠️
glue_jupyter/app.py 62.50% 9 Missing ⚠️
glue_jupyter/tests/test_session.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   86.07%   85.84%   -0.24%     
==========================================
  Files          90       92       +2     
  Lines        5242     5312      +70     
==========================================
+ Hits         4512     4560      +48     
- Misses        730      752      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog
Copy link
Member Author

Note to self, if glue-jupyter is installed it will break session loading in glue-qt as the plugin will always apply the patches. I need to find a way of conditionally applying it just when loaded from Jupyter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant