-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose 'png' image compression in BqplotImageView by default #470
Conversation
The visual change is ok, so we can put the hash somewhere to indicate this is good, this should be documented at https://pytest-mpl.readthedocs.io/en/stable/hash_mode.html Do you want to try this @bmorris3, or should we ask @astrofrog ? |
@Carifio24, @astrofrog, are there any tools to run the |
I experimented a bunch, and settled on generating updated hashes with: tox -e py311-test-visual -- --mpl-results-path=results I've put the resulting hashes in the latest commit, I guess we'll see if that's ok? |
The |
@dhomeier the CircleCI job updates the reference images |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 90 90
Lines 5242 5242
=======================================
Hits 4512 4512
Misses 730 730 ☔ View full report in Codecov by Sentry. |
Did you enable that job somehow? I noticed one job that required approval before, but first wanted to fix the checksums, and now it seems to have disappeared again. |
@dhomeier - the job to update the reference images only happens on main after a PR has been merged. All that is needed for a PR to pass is for the hashes to be correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all!
Description
Allow users to take advantage of PNG compression via
ImageGL
from glue-viz/bqplot-image-gl#109. Bumping pin forbqplot-image-gl
.