-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nifti misc improvements #7
base: main
Are you sure you want to change the base?
Conversation
3c0caae
to
9a72c39
Compare
@AndrewBeers - I had forgotten to commit utils.py, which I've done now - sorry! |
.travis.yml
Outdated
@@ -10,7 +10,7 @@ env: | |||
- SETUP_XVFB=True | |||
- CONDA_CHANNELS="conda-forge" | |||
- CONDA_DEPENDENCIES="glueviz pytest mock requests" | |||
- PIP_DEPENDENCIES="pydicom" | |||
- PIP_DEPENDENCIES="pydicom, nibabel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the comma here
There are some files that were added here that shouldn't be - specifically all the files in glue_medical.egg-info - can you remove these? By the way, I've just pushed a commit to master to add a .gitignore file (which was missing previously). I also fixed the DICOM tests. Could you rebase this branch? EDIT: just remembered we had added a .gitignore file here, oops |
@AndrewBeers - thanks for continuing work on this! Just so you know, since we last worked on this I've now added the ability to write custom subset mask importers/exporters: http://glueviz.org/en/stable/customizing_guide/customization.html#custom-subset-mask-importers This is different from the Data/Subset exporter: http://glueviz.org/en/stable/customizing_guide/customization.html#custom-data-subset-exporters because in the latter, the values of the subset should be exported, as opposed to the mask. |
working on: nrrd importer
26835b5
to
ceb851d
Compare
This pull requests represents a few of QTIM lab's contributions to glue medical, especially pertaining to Nifti file formats and exporting subsets. More to come.
Remaining things to do: