fix: get network gateway SSID and signal strength using Windows APIs #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-berger
requested changes
Oct 10, 2024
|
Fixed requested changes. |
lars-berger
changed the title
|
Perfect!! Thanks a bunch 🙌 |
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zebar was using
netshto get wifi data and then parse it using regex. That lead to some issues (#96) asnetshtranslates the data to the os language.I have rewritten the whole
wifi_hotspot.rsfile to use the Windows API instead. This should be less error prone, but I had to use some unsafe functions and pointers that needed to be freed. After handling those I don't see any memory leaks in my tests, but it may be worth testing that again. Also, it should work with any Windows version that Tauri works on, but I can only test in Windows 10.Let me know of any question or suggestion.
Closes #96
Side note: I have removed the
Win32_System_Threadingfeature as it doesn't seem to be used anywhere else.