feat: add disk provider
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-berger
reviewed
Nov 4, 2024
|
|
||
| let mut list = Vec::new(); | ||
|
|
||
| for disk in disks.iter() { |
There was a problem hiding this comment.
could use .map(...).collect::<Vec<_>>() to simplify this and avoid the mut on list
| total_space: disk.total_space(), | ||
| available_space: disk.available_space(), | ||
| is_removable: disk.is_removable(), | ||
| disk_type: format!("{:?}", disk.kind()), |
There was a problem hiding this comment.
disk.kind().display() can be used instead of format!(...)
lars-berger
reviewed
Nov 4, 2024
|
Much needed, thank you 🙌 To fix formatting you can use |
|
Thanks for the feedback, really appreciated! Have gone ahead and made some changes, please let me know if I've missed anything or made things worse!
|
veryard
force-pushed
the
dev/disk-widget
branch
from
d3d9f12 to
f2318a3
Compare
veryard
force-pushed
the
dev/disk-widget
branch
from
e8ae8a9 to
1fa1aae
Compare
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a widget for disk information, uses the
sysinfopackage that is already included within.