Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rtd config file #220

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Update rtd config file #220

merged 4 commits into from
Dec 20, 2023

Conversation

adam-a-a
Copy link
Contributor

@adam-a-a adam-a-a commented Dec 18, 2023

Addresses issue:

Summary/Motivation:

Readthedocs check is failing and other checks won't run until the RTD check passes. Let's fix it.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adam-a-a adam-a-a marked this pull request as ready for review December 18, 2023 17:20
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Dec 18, 2023
ksbeattie
ksbeattie previously approved these changes Dec 18, 2023
Copy link
Contributor

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie mentioned this pull request Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (696dacc) 89.83% compared to head (9c187c1) 89.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          77       77           
  Lines        9307     9307           
=======================================
  Hits         8361     8361           
  Misses        946      946           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bknueven bknueven merged commit a9e9b7a into gmlc-dispatches:main Dec 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants