Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: start unit after multi-user.target #37

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

gmodena
Copy link
Owner

@gmodena gmodena commented Feb 7, 2024

Start the flatpak-managed-install service after multi-user.target.
This should ensure that network interfaces are up, and connectivity has been established.

Fixes #30

@ReedClanton
Copy link
Contributor

This has been working for me for the last few days. Having said that, I haven't tried adding to removing flatpaks, so the testing is limited.

Start the flatpak-managed-install service after
multi-user.target.
This should ensure that network interfaces are up,
and connectivity has been established.
This is not really needed, since state changes
will be handled by a timer.
@gmodena
Copy link
Owner Author

gmodena commented Feb 14, 2024

Thanks for the ack @ReedClanton . I've been daily driving the change for a while and encountered no obvious regression. I suspect this behavior is system dependent (e.g. I manage the network stack differently on my laptops vs vms), so I might need to revisit the systemd units at some point.

@gmodena gmodena changed the title WIP: systemd: start unit after multi-user.targer. systemd: start unit after multi-user.targer. Feb 14, 2024
@gmodena gmodena changed the title systemd: start unit after multi-user.targer. systemd: start unit after multi-user.target Feb 14, 2024
@ReedClanton
Copy link
Contributor

Setup

wpa_supplicant manages wireless connections and NetworkManager manages wired.

Testing

  • Turned off wpa_supplicant so NetworkManager handled wireless and rebooted:
    • ✔️
  • Removed Ethernet connection so now connected via wireless with NetworkManager and rebooted:
    • ✔️
  • Removed source of wireless connection (not connected to the internet at all) and rebooted:
    • ✔️
  • Re-enabled wpa_supplicant but still no source of internet (wired or wireless) and rebooted:
    • ✔️
  • Created wireless source but still didn't plug Ethernet back in (connected via wpa_supplicant) and rebooted:
    • ✔️
  • Plugged Ethernet back in (back to normal setup) and rebooted:
    • ✔️

TL;DR

Did a little testing of different network management setups and connection methods/status and didn't see any issue. Not rigerus testing (took longer to write this up), but it was something.

@gmodena gmodena merged commit 2fd683c into main Feb 15, 2024
1 check passed
@gmodena gmodena deleted the fix-boot-activation branch October 20, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatpak-managed-install.service fails to start properly when update.onactivation set to true (v0.2.0)
2 participants