Allowed Slippage for limit swaps #1451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hubert-de-lalye
commented
Dec 12, 2024
•
hubert-de-lalye
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208764027793564
✅ Deploy Preview for vigilant-albattani-df38ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying gmx-interface with
|
| Latest commit: |
b895c8b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b71e630.gmx-interface.pages.dev |
| Branch Preview URL: | https://swap-impact-field.gmx-interface.pages.dev |
hubert-de-lalye
changed the title
…ed slippage on token input change
hubert-de-lalye
force-pushed
the
swap-impact-field
branch
from
616045d to
13e8a75
Compare
hubert-de-lalye
changed the title
divhead
reviewed
Dec 17, 2024
| swapPath = allPaths[0].path; | ||
| const sortedPaths = opts.order | ||
| ? [...allPaths].sort((a, b) => { | ||
| for (const field of opts.order ?? []) { |
There was a problem hiding this comment.
oh, maybe create different sort functions for sort each strategy?
There was a problem hiding this comment.
I moved this to separated getSwapPathComparator and added unit tests for it, it's a generic function and strategy passed as priority list of liquidity and/or path length
divhead
reviewed
Dec 17, 2024
| initialSwapImpactFeeBps?: bigint; | ||
| setAllowedSwapSlippageBps: (value: bigint) => void; | ||
| totalSwapImpactBps: bigint; | ||
| notAvailable?: boolean; |
There was a problem hiding this comment.
not critial, but, probably rename it to “disabled”? would be a more familiar name
There was a problem hiding this comment.
this inherited from AcceptableSwapImpact component, and I think naming is ok cuz it will render N/A, it's differs from just disabled state
divhead
reviewed
Dec 17, 2024
divhead
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.