Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cancel for __on_player_command #1739 #1740

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add cancel for __on_player_command #1739 #1740

wants to merge 4 commits into from

Conversation

shenjackyuanjie
Copy link

@shenjackyuanjie shenjackyuanjie commented Jun 7, 2023 •
edited
Loading

fix #1739

@shenjackyuanjie shenjackyuanjie changed the title add cancel for __on_player_command add cancel for __on_player_command # 1739 Jun 7, 2023
@shenjackyuanjie shenjackyuanjie changed the title add cancel for __on_player_command # 1739 add cancel for __on_player_command #1739 Jun 7, 2023
@replaceitem
Copy link
Contributor

Do not edit the Full.md file, since that gets automatically generated from the other doc files when they are updated.

@shenjackyuanjie
Copy link
Author

Do not edit the Full.md file, since that gets automatically generated from the other doc files when they are updated.

oh! got it

@altrisi
Copy link
Collaborator

altrisi commented Jul 28, 2023

This breaks signatures for commands with signed components (like /tell).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harveykang Harveykang Harveykang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__on_player_command cannot be canceled
4 participants
@shenjackyuanjie @replaceitem @altrisi @Harveykang