-
Notifications
You must be signed in to change notification settings - Fork 385
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: Upgrade go.uber.org/zap/exp to v0.3.0 (to fix dependabot upgra…
…des) (#3378) Dependabot PRs #3306 and #3343 want to (among other things) upgrade go.uber.org/zap/exp from v0.2.0 to v0.3.0 . This causes a nil pointer exception because of [this code](https://github.com/gnolang/gno/blob/master/gno.land/pkg/log/zap.go#L74): ``` return slog.New(zapslog.NewHandler(logger.Core(), nil)) ``` The problem is that go.uber.org/zap/exp v0.2.0 has: ``` func NewHandler(core zapcore.Core, opts *HandlerOptions) *Handler ``` but v0.3.0 has: ``` func NewHandler(core zapcore.Core, opts ...HandlerOption) *Handler ``` Thus, it views the nil second argument as a nil `HandlerOption`. The fix is to simply remove the second argument in the call to `NewHandler`. When this is merged, we can tell dependabot to rebase the original PRs and the CI tests should pass. Signed-off-by: Jeff Thompson <[email protected]> Co-authored-by: Morgan <[email protected]>
- Loading branch information
Showing
8 changed files
with
12 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.