Skip to content

Commit

Permalink
fix(gnovm): make static-analysis handle block stmt (#3313)
Browse files Browse the repository at this point in the history
as the title says.

it give incorrect error before fix:
```
unexpected panic: main/files/block0.gno:3:1: [function "foo" does not terminate]
```
  • Loading branch information
ltzmaxwell authored Dec 10, 2024
1 parent 4e7305b commit 5c31552
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
2 changes: 2 additions & 0 deletions gnovm/pkg/gnolang/static_analysis.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ func (s *staticAnalysis) staticAnalysisExpr(expr Expr) bool {
// indicating whether a statement is terminating or not
func (s *staticAnalysis) staticAnalysisStmt(stmt Stmt) bool {
switch n := stmt.(type) {
case *BlockStmt:
return s.staticAnalysisBlockStmt(n.Body)
case *BranchStmt:
switch n.Op {
case BREAK:
Expand Down
14 changes: 14 additions & 0 deletions gnovm/tests/files/block0.gno
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package main

func foo() int {
{
return 1
}
}

func main() {
println(foo())
}

// Output:
// 1

0 comments on commit 5c31552

Please sign in to comment.