-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlibs): add encoding
, encoding/{base32,binary,csv}
#1290
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
converting to draft for now, mark as ready when it's done :) full implementation of encoding/binary requires reflection; not sure what category I put it into but if you just do varint it should be good 👍 |
@thehowl Thanks! I'll trying to finishing |
don't forget to update the docs/ folder, thank you. |
@moul don't worry, I'll update together when it's done. |
encoding
, encoding/{base32,binary,csv}
encoding
, encoding/{base32,binary,csv}
encoding
, encoding/{base32,binary,csv}
@notJoon please fix tests :) ( if you need any help ping me on signal |
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
PR is now ready, but depends on two other PRs to fix VM bugs which were causing problems in the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start looking
…g#1290) - [X] `encoding` - [X] `encoding/base32` - [X] `encoding/binary` - [X] `encoding/csv` : Due to the `reflect` does not implemented yet, skipped `fuzz` --- 1. `encoding/asn1`: better after `reflection` related to: - gnoswap-labs#7 - gnolang#1267 depends-on: - gnolang#3296 - gnolang#3298 --------- Co-authored-by: Morgan Bazalgette <[email protected]> Co-authored-by: ltzmaxwell <[email protected]>
encoding
encoding/base32
encoding/binary
encoding/csv
: Due to thereflect
does not implemented yet, skippedfuzz
encoding/asn1
: better afterreflection
related to:
depends-on: