Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlibs): add encoding, encoding/{base32,binary,csv} #1290

Merged
merged 48 commits into from
Dec 25, 2024

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Oct 25, 2023

  • encoding
  • encoding/base32
  • encoding/binary
  • encoding/csv : Due to the reflect does not implemented yet, skipped fuzz

  1. encoding/asn1: better after reflection

related to:

depends-on:

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@notJoon notJoon marked this pull request as ready for review October 26, 2023 08:28
@notJoon notJoon requested review from jaekwon, moul and a team as code owners October 26, 2023 08:28
@thehowl thehowl marked this pull request as draft October 26, 2023 16:49
@thehowl
Copy link
Member

thehowl commented Oct 26, 2023

converting to draft for now, mark as ready when it's done :)

full implementation of encoding/binary requires reflection; not sure what category I put it into but if you just do varint it should be good 👍

@notJoon
Copy link
Member Author

notJoon commented Oct 27, 2023

@thehowl Thanks! I'll trying to finishing varint first 👍 👍

@notJoon
Copy link
Member Author

notJoon commented Oct 27, 2023

test
The original test code encountered a segment fault. So, I converted the exmaple code in the package document to gno test code.

@moul
Copy link
Member

moul commented Oct 29, 2023

don't forget to update the docs/ folder, thank you.

@notJoon
Copy link
Member Author

notJoon commented Oct 30, 2023

@moul don't worry, I'll update together when it's done.

@notJoon
Copy link
Member Author

notJoon commented Oct 31, 2023

base32 testing result

Finally solved the base32 decoder part that wasn't working. Additionaly, I also added some use cases to validate the package's functionalities.

@notJoon notJoon marked this pull request as ready for review October 31, 2023 02:42
@thehowl thehowl changed the title feat: add encoding stdlib feat(stdlibs)): add encoding, encoding/{base32,binary,csv} Nov 9, 2023
@thehowl thehowl changed the title feat(stdlibs)): add encoding, encoding/{base32,binary,csv} feat(stdlibs): add encoding, encoding/{base32,binary,csv} Nov 9, 2023
@thehowl
Copy link
Member

thehowl commented Nov 9, 2023

@notJoon please fix tests :) (make _test.gnolang.stdlibs in gnovm, and run make fmt as well)

if you need any help ping me on signal

@thehowl thehowl marked this pull request as draft April 9, 2024 15:23
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 8, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: notJoon/gno-core)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@thehowl thehowl marked this pull request as ready for review December 8, 2024 12:18
@thehowl
Copy link
Member

thehowl commented Dec 8, 2024

PR is now ready, but depends on two other PRs to fix VM bugs which were causing problems in the tests

@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 9, 2024
@thehowl thehowl requested a review from ltzmaxwell December 17, 2024 19:25
Copy link
Contributor

@ltzmaxwell ltzmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start looking

gnovm/pkg/gnolang/op_binary.go Outdated Show resolved Hide resolved
@ltzmaxwell ltzmaxwell merged commit ea32315 into gnolang:master Dec 25, 2024
62 checks passed
moul pushed a commit to moul/gno that referenced this pull request Dec 27, 2024
…g#1290)

- [X] `encoding`
- [X] `encoding/base32`
- [X] `encoding/binary`
- [X] `encoding/csv` : Due to the `reflect` does not implemented yet,
skipped `fuzz`
---
1. `encoding/asn1`: better after `reflection`

related to:
 - gnoswap-labs#7
 - gnolang#1267

depends-on:

- gnolang#3296 
- gnolang#3298

---------

Co-authored-by: Morgan Bazalgette <[email protected]>
Co-authored-by: ltzmaxwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in focus Core team is prioritizing this work 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants