Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gnoweb UI styles #3349

Merged
merged 25 commits into from
Dec 17, 2024
Merged

fix: gnoweb UI styles #3349

merged 25 commits into from
Dec 17, 2024

Conversation

alexiscolin
Copy link
Member

@alexiscolin alexiscolin commented Dec 17, 2024

This PR aims to fix some of remaining UI bugs on gnoweb after the revamp merge.

Some of: #3355

  • Fixes Safari select input design and icons
  • Fixes input hover
  • Fixes ToC font style
  • Fixes UI details and improve CSS
  • Fixes Responsive with long content
  • Fixes Scrollbar
  • Fixes fonts loading strategy and size
  • Fixes ts issue with copy btn (quick clicks)
  • Fixes some A11y

@alexiscolin alexiscolin requested a review from gfanton December 17, 2024 07:31
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Dec 17, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 17, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • SKIP: Do not block the CI for this PR
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 The pull request head branch must be up-to-date with its base (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: alexiscolin/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (alexiscolin:fix/gnoweb-ui-style) is up to date with base (master): behind by 0 / ahead by 25

Manual Checks
**SKIP**: Do not block the CI for this PR

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@alexiscolin alexiscolin added the 🌍 gnoweb Issues & PRs related to gnoweb and render label Dec 17, 2024
@thehowl thehowl merged commit 0408d6f into gnolang:master Dec 17, 2024
108 of 110 checks passed
n0izn0iz pushed a commit to TERITORI/gno that referenced this pull request Dec 17, 2024
This PR aims to fix some of remaining UI bugs on gnoweb after the revamp
merge.

Some of: gnolang#3355

- Fixes Safari select input design and icons
- Fixes input hover
- Fixes ToC font style
- Fixes UI details and improve CSS
- Fixes Responsive with long content
- Fixes Scrollbar
- Fixes fonts loading strategy and size
- Fixes ts issue with copy btn (quick clicks)
- Fixes some A11y
omarsy pushed a commit to omarsy/gno that referenced this pull request Dec 18, 2024
This PR aims to fix some of remaining UI bugs on gnoweb after the revamp
merge.

Some of: gnolang#3355

- Fixes Safari select input design and icons
- Fixes input hover
- Fixes ToC font style
- Fixes UI details and improve CSS
- Fixes Responsive with long content
- Fixes Scrollbar
- Fixes fonts loading strategy and size
- Fixes ts issue with copy btn (quick clicks)
- Fixes some A11y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌍 gnoweb Issues & PRs related to gnoweb and render 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Development

Successfully merging this pull request may close these issues.

4 participants