-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): update avlhelpers
to use avl.ITree
#3377
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Hey @jefft0, I made this PR because the upcoming r/demo/users refactor (#3166) will change the API of the r/users system. Essentially, instead of exposing a Hope I was clear, let me know if otherwise. I will keep you up to speed on the progress of the refactor PR, after which you will need to update your realms as well (hoping for merge mid jan) |
Hi @leohhhn . You mention the change to |
Ideally we would use |
Yes, it would be ideal. If you want to show best practice, do you want to change this PR to update all the realm code to use |
Sure, let me take a detalied look. 👍 |
Hi @leohhhn . moul merged this PR. I guess we can deal with updating |
Description
Updates the
avlhelpers
package to use the newavl.ITree
interface.