Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add r/demo/tests/test20 + add grc20.TokenGetter to reduce boilerplate when using grc20reg #3397

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

moul
Copy link
Member

@moul moul commented Dec 21, 2024

  • add r/demo/tests/test20
  • add grc20.TokenGetter to reduce boilerplate when using grc20reg.Register(...)

Replaces #2549
Continues #3135

@moul moul self-assigned this Dec 21, 2024
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 21, 2024
@moul moul mentioned this pull request Dec 21, 2024
5 tasks
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 21, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul moul changed the title dev/moul/grc20reg getter chore: add r/demo/tests/test20 + add grc20.TokenGetter to reduce boilerplate when using grc20reg Dec 21, 2024
Signed-off-by: moul <[email protected]>
@moul moul force-pushed the dev/moul/grc20reg-getter branch from e9a6b32 to 90a15aa Compare December 21, 2024 01:08
@moul moul marked this pull request as ready for review December 21, 2024 01:09
@moul moul merged commit 597f3f5 into gnolang:master Dec 28, 2024
20 of 21 checks passed
@moul moul deleted the dev/moul/grc20reg-getter branch December 28, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants