-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnovm): add gno test parallel package testing #3431
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
37424f8
to
707182e
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: gfanton <[email protected]>
&c.parallel, | ||
"parallel", | ||
1, | ||
"number of package to run concurrently (default(1): sequentially); 0 = GOMAXPROCESS", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be great to run tests in parallel within the same package as well. A recent change I made was to ensure each test is independent; if there is a global variable, it is always set up again. This is probably easy to implement.
This PR improves the speed of running
gnovm
tests.stdlibs
tests fromgnovm
go tests by usinggno test
directly in separate job on the CI.parallel
package test flags forgno test
.As a result, this PR reduces the test time of the gnovm test suite to below
5m
.