Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnovm): add gno test parallel package testing #3431

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Dec 31, 2024

This PR improves the speed of running gnovm tests.

  • It separates gno stdlibs tests from gnovm go tests by using gno test directly in separate job on the CI.
  • It adds parallel package test flags for gno test.

As a result, this PR reduces the test time of the gnovm test suite to below 5m.

@gfanton gfanton self-assigned this Dec 31, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Dec 31, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 31, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: gfanton/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@gfanton gfanton changed the title feat(gnovm): add gno test parallel package testing wip(gnovm): add gno test parallel package testing Dec 31, 2024
@gfanton gfanton force-pushed the fix/gnoland/test-speed-pt2 branch from 37424f8 to 707182e Compare December 31, 2024 13:51
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/cmd/gno/test.go 96.49% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: gfanton <[email protected]>
@gfanton gfanton changed the title wip(gnovm): add gno test parallel package testing feat(gnovm): add gno test parallel package testing Dec 31, 2024
&c.parallel,
"parallel",
1,
"number of package to run concurrently (default(1): sequentially); 0 = GOMAXPROCESS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be great to run tests in parallel within the same package as well. A recent change I made was to ensure each test is independent; if there is a global variable, it is always set up again. This is probably easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants