feat: cache by metadigest #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannafransn
approved these changes
Oct 31, 2024
vibern0
deleted the
bernardovieira/gw-1010-profile-data-doesnt-update-after-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as reported, profile data was not being updated. This is because cache was saved by avatar id, and if there was cache, it would return instead of update. This solves that problem, and instead indexes by metadigest, which reduces computation, since we only need to compute the cid once, to query it.
it also fixes group profile creation since
UpdateMetadataDigestevent is emitted before theRegisterGroupevent in case the user sets profile data already.